]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: kpc2000: kpc_i2c: Use drvdata instead of platform_data
authorGeordan Neukum <gneukum1@gmail.com>
Sun, 26 May 2019 01:18:31 +0000 (01:18 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2019 21:04:26 +0000 (14:04 -0700)
The kpc_i2c driver stashes private state data in the platform_data
member of its device structure. In general, the platform_data structure
is used for passing data to the driver during probe() rather than as a
storage area for runtime state data. Instead, use the drvdata member
for all state info meant to be accessible in driver callbacks.

Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_i2c.c

index 1767f351a11655c421c961d7b3df40be6d8408e7..e4bbb91af97254ccbfbff7ee40420f4b0d9be5fb 100644 (file)
@@ -589,7 +589,7 @@ static int pi2c_probe(struct platform_device *pldev)
        res = platform_get_resource(pldev, IORESOURCE_MEM, 0);
        priv->smba = (unsigned long)ioremap_nocache(res->start, resource_size(res));
 
-       pldev->dev.platform_data = priv;
+       platform_set_drvdata(pldev, priv);
 
        priv->features |= FEATURE_IDF;
        priv->features |= FEATURE_I2C_BLOCK_READ;
@@ -620,7 +620,7 @@ static int pi2c_remove(struct platform_device *pldev)
 {
        struct i2c_device *lddev;
 
-       lddev = (struct i2c_device *)pldev->dev.platform_data;
+       lddev = (struct i2c_device *)platform_get_drvdata(pldev);
 
        i2c_del_adapter(&lddev->adapter);