]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
HID: hid-input: Add parentheses to quell gcc warning
authorJames C Boyd <jcboyd.dev@gmail.com>
Wed, 27 May 2015 22:09:06 +0000 (17:09 -0500)
committerJiri Kosina <jkosina@suse.cz>
Thu, 28 May 2015 08:41:44 +0000 (10:41 +0200)
GCC reports a -Wlogical-not-parentheses warning here; therefore
add parentheses to shut it up and to express our intent more.

Signed-off-by: James C Boyd <jcboyd.dev@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-input.c

index 008e89bf6f3c3d112d92640bdf91f1e935e0641c..714b75891ec0f41122716e0fc9d34f67c124371d 100644 (file)
@@ -1157,7 +1157,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
                return;
 
        /* report the usage code as scancode if the key status has changed */
-       if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
+       if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value)
                input_event(input, EV_MSC, MSC_SCAN, usage->hid);
 
        input_event(input, usage->type, usage->code, value);