]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi: mpc52xx: Use gpio_is_valid()
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 27 Apr 2018 11:02:17 +0000 (16:32 +0530)
committerMark Brown <broonie@kernel.org>
Fri, 27 Apr 2018 11:05:39 +0000 (12:05 +0100)
Replace the manual validity checks for the GPIO with the
gpio_is_valid().

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mpc52xx.c

index e8b59ce4dc3a74153cb15ef9f128b44070a573da..0e55784a3ad93604634a1241b630ada7106b10e6 100644 (file)
@@ -447,7 +447,7 @@ static int mpc52xx_spi_probe(struct platform_device *op)
 
                for (i = 0; i < ms->gpio_cs_count; i++) {
                        gpio_cs = of_get_gpio(op->dev.of_node, i);
-                       if (gpio_cs < 0) {
+                       if (!gpio_is_valid(gpio_cs)) {
                                dev_err(&op->dev,
                                        "could not parse the gpio field in oftree\n");
                                rc = -ENODEV;