]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
selftests: pmtu: properly redirect stderr to /dev/null
authorSabrina Dubroca <sd@queasysnail.net>
Mon, 17 Sep 2018 13:30:06 +0000 (15:30 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Sep 2018 02:53:58 +0000 (19:53 -0700)
The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually
send stderr to /dev/null, so when the netns doesn't exist, the error
message is shown. Use "2> /dev/null" instead, so that those messages
disappear, as was intended.

Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Acked-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/pmtu.sh

index 32a194e3e07a5a60d4c00dfdcfd25ad31ef38b6e..0ab9423d009f5b8c189dddb4a1f8f81c8a3a2101 100755 (executable)
@@ -178,8 +178,8 @@ setup() {
 
 cleanup() {
        [ ${cleanup_done} -eq 1 ] && return
-       ip netns del ${NS_A} 2 > /dev/null
-       ip netns del ${NS_B} 2 > /dev/null
+       ip netns del ${NS_A} 2> /dev/null
+       ip netns del ${NS_B} 2> /dev/null
        cleanup_done=1
 }