]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iommu/mediatek: Fix handling of of_count_phandle_with_args result
authorAndrzej Hajda <a.hajda@samsung.com>
Tue, 1 Mar 2016 09:36:23 +0000 (10:36 +0100)
committerJoerg Roedel <jroedel@suse.de>
Tue, 1 Mar 2016 11:33:46 +0000 (12:33 +0100)
The function can return negative value so it should be assigned to signed
variable. The patch changes also type of related i variable to make code
more compact and coherent.

The problem has been detected using patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/mtk_iommu.c

index f3c160e4c25df6b5a56acf002c519aff36ee91fc..4b9ae64c2fc3be0b88341aba85f0748b9c7e9eff 100644 (file)
@@ -578,8 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
        struct resource         *res;
        struct component_match  *match = NULL;
        void                    *protect;
-       unsigned int            i, larb_nr;
-       int                     ret;
+       int                     i, larb_nr, ret;
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
        if (!data)