]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
video: fbdev: radeon: make const array post_divs static, reduces object code size
authorColin Ian King <colin.king@canonical.com>
Thu, 12 Oct 2017 16:28:26 +0000 (18:28 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Thu, 12 Oct 2017 16:28:26 +0000 (18:28 +0200)
Don't populate the read-only const array post_divs on the stack,
instead make it static. Makes the object code smaller by 90 bytes:

Before:
   text    data     bss     dec     hex filename
  40231    8584     896   49711    c22f radeon_base.o

After:
   text    data     bss     dec     hex filename
  39914    8744     960   49618    c1d2 radeon_base.o

(gcc version 7.2.0, x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/aty/radeon_base.c

index 1e2ec360f8c16da91b8ee9e921452ef4bda77834..8ad1643e7d1ca18b8eaa63c0d0a1a18d6ce4ba5c 100644 (file)
@@ -1534,7 +1534,7 @@ void radeon_write_mode (struct radeonfb_info *rinfo, struct radeon_regs *mode,
 static void radeon_calc_pll_regs(struct radeonfb_info *rinfo, struct radeon_regs *regs,
                                 unsigned long freq)
 {
-       const struct {
+       static const struct {
                int divider;
                int bitvalue;
        } *post_div,