]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: socionext: netsec: fix xdp stats accounting
authorLorenzo Bianconi <lorenzo@kernel.org>
Thu, 17 Oct 2019 12:28:32 +0000 (14:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Oct 2019 19:02:33 +0000 (15:02 -0400)
Increment netdev rx counters even for XDP_DROP verdict. Report even
tx bytes for xdp buffers (TYPE_NETSEC_XDP_TX or TYPE_NETSEC_XDP_NDO).
Moreover account pending buffer length in netsec_xdp_queue_one as it is
done for skb counterpart

Tested-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/socionext/netsec.c

index f9e6744d8fd6ea0527a86271044d400788158a27..c40294470bfa3c15316c968a3e9f0f954f43ff42 100644 (file)
 #define NETSEC_XDP_CONSUMED      BIT(0)
 #define NETSEC_XDP_TX            BIT(1)
 #define NETSEC_XDP_REDIR         BIT(2)
-#define NETSEC_XDP_RX_OK (NETSEC_XDP_PASS | NETSEC_XDP_TX | NETSEC_XDP_REDIR)
 
 enum ring_id {
        NETSEC_RING_TX = 0,
@@ -661,6 +660,7 @@ static bool netsec_clean_tx_dring(struct netsec_priv *priv)
                        bytes += desc->skb->len;
                        dev_kfree_skb(desc->skb);
                } else {
+                       bytes += desc->xdpf->len;
                        xdp_return_frame(desc->xdpf);
                }
 next:
@@ -858,6 +858,7 @@ static u32 netsec_xdp_queue_one(struct netsec_priv *priv,
        tx_desc.addr = xdpf->data;
        tx_desc.len = xdpf->len;
 
+       netdev_sent_queue(priv->ndev, xdpf->len);
        netsec_set_tx_de(priv, tx_ring, &tx_ctrl, &tx_desc, xdpf);
 
        return NETSEC_XDP_TX;
@@ -1030,7 +1031,7 @@ static int netsec_process_rx(struct netsec_priv *priv, int budget)
 
 next:
                if ((skb && napi_gro_receive(&priv->napi, skb) != GRO_DROP) ||
-                   xdp_result & NETSEC_XDP_RX_OK) {
+                   xdp_result) {
                        ndev->stats.rx_packets++;
                        ndev->stats.rx_bytes += xdp.data_end - xdp.data;
                }