]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PCI: vmd: Move SRCU cleanup after bus, child device removal
authorJon Derrick <jonathan.derrick@intel.com>
Thu, 22 Jun 2017 15:15:42 +0000 (09:15 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Sun, 2 Jul 2017 23:47:15 +0000 (18:47 -0500)
Recent __call_srcu() changes have exposed that we need to cleanup SRCU
structures after pci_stop_root_bus() calls into vmd_msi_free().

Fixes: 3906b91844d6 ("PCI: vmd: Use SRCU as a local RCU to prevent delaying global RCU")
Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Keith Busch <keith.busch@intel.com>
Cc: <stable@vger.kernel.org> # 4.11
drivers/pci/host/vmd.c

index 53aa1d4b17e889694114d489a9ba2b864a43fe1c..9d83f37b4cb71847d87dab02b674b47228ec2592 100644 (file)
@@ -736,10 +736,10 @@ static void vmd_remove(struct pci_dev *dev)
        struct vmd_dev *vmd = pci_get_drvdata(dev);
 
        vmd_detach_resources(vmd);
-       vmd_cleanup_srcu(vmd);
        sysfs_remove_link(&vmd->dev->dev.kobj, "domain");
        pci_stop_root_bus(vmd->bus);
        pci_remove_root_bus(vmd->bus);
+       vmd_cleanup_srcu(vmd);
        vmd_teardown_dma_ops(vmd);
        irq_domain_remove(vmd->irq_domain);
 }