]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
infiniband: qib: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 15:17:56 +0000 (16:17 +0100)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 24 Jan 2019 16:22:29 +0000 (09:22 -0700)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/qib/qib_debugfs.c

index 5ed1ed93380f550987e4148eaff4fbabc1019883..caeb77d07a58597e661f5d693d09395864ebb691 100644 (file)
@@ -66,15 +66,6 @@ static const struct file_operations _##name##_file_ops = { \
        .release = seq_release \
 };
 
-#define DEBUGFS_FILE_CREATE(name) \
-do { \
-       struct dentry *ent; \
-       ent = debugfs_create_file(#name , 0400, ibd->qib_ibdev_dbg, \
-               ibd, &_##name##_file_ops); \
-       if (!ent) \
-               pr_warn("create of " #name " failed\n"); \
-} while (0)
-
 static void *_opcode_stats_seq_start(struct seq_file *s, loff_t *pos)
 {
        struct qib_opcode_stats_perctx *opstats;
@@ -249,17 +240,17 @@ DEBUGFS_FILE(qp_stats)
 
 void qib_dbg_ibdev_init(struct qib_ibdev *ibd)
 {
+       struct dentry *root;
        char name[10];
 
        snprintf(name, sizeof(name), "qib%d", dd_from_dev(ibd)->unit);
-       ibd->qib_ibdev_dbg = debugfs_create_dir(name, qib_dbg_root);
-       if (!ibd->qib_ibdev_dbg) {
-               pr_warn("create of %s failed\n", name);
-               return;
-       }
-       DEBUGFS_FILE_CREATE(opcode_stats);
-       DEBUGFS_FILE_CREATE(ctx_stats);
-       DEBUGFS_FILE_CREATE(qp_stats);
+       root = debugfs_create_dir(name, qib_dbg_root);
+       ibd->qib_ibdev_dbg = root;
+
+       debugfs_create_file("opcode_stats", 0400, root, ibd,
+                           &_opcode_stats_file_ops);
+       debugfs_create_file("ctx_stats", 0400, root, ibd, &_ctx_stats_file_ops);
+       debugfs_create_file("qp_stats", 0400, root, ibd, &_qp_stats_file_ops);
 }
 
 void qib_dbg_ibdev_exit(struct qib_ibdev *ibd)
@@ -274,8 +265,6 @@ void qib_dbg_ibdev_exit(struct qib_ibdev *ibd)
 void qib_dbg_init(void)
 {
        qib_dbg_root = debugfs_create_dir(QIB_DRV_NAME, NULL);
-       if (!qib_dbg_root)
-               pr_warn("init of debugfs failed\n");
 }
 
 void qib_dbg_exit(void)