]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
rpmsg: smd: Use announce_create to process any receive work
authorBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 27 Mar 2018 21:06:43 +0000 (14:06 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 28 Mar 2018 04:54:37 +0000 (21:54 -0700)
It is possible that incoming data arrives before the client driver has
reached a point in the probe method where adequate context for handling
the incoming message has been established.

In the event that the client's callback function returns an error the
message will be left on the FIFO and by invoking the receive handler
after the device has been probed the message will be picked off the FIFO
and the callback invoked again.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/rpmsg/qcom_smd.c

index 35089039a33550e5810fd2f9385debbc3abfb7ba..5ce9bf7b897d82da403c489ed69abd3ec5de41d5 100644 (file)
@@ -997,8 +997,26 @@ static struct device_node *qcom_smd_match_channel(struct device_node *edge_node,
        return NULL;
 }
 
+static int qcom_smd_announce_create(struct rpmsg_device *rpdev)
+{
+       struct qcom_smd_endpoint *qept = to_smd_endpoint(rpdev->ept);
+       struct qcom_smd_channel *channel = qept->qsch;
+       unsigned long flags;
+       bool kick_state;
+
+       spin_lock_irqsave(&channel->recv_lock, flags);
+       kick_state = qcom_smd_channel_intr(channel);
+       spin_unlock_irqrestore(&channel->recv_lock, flags);
+
+       if (kick_state)
+               schedule_work(&channel->edge->state_work);
+
+       return 0;
+}
+
 static const struct rpmsg_device_ops qcom_smd_device_ops = {
        .create_ept = qcom_smd_create_ept,
+       .announce_create = qcom_smd_announce_create,
 };
 
 static const struct rpmsg_endpoint_ops qcom_smd_endpoint_ops = {