]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/i915: Silence sparse by using gfp_t
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 1 Sep 2017 14:57:28 +0000 (15:57 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 5 Sep 2017 10:56:26 +0000 (11:56 +0100)
Sparse enforces that GFP flags are only manipulated inside gfp_t locals.

Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170901145729.21363-1-chris@chris-wilson.co.uk
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/i915_gem_execbuffer.c

index 8a9d37ac16d4773c9f89602b01bfd28c0b488a80..67317b79b9e096062384600688d7ae32d297b325 100644 (file)
@@ -290,7 +290,7 @@ static int eb_create(struct i915_execbuffer *eb)
                 * direct lookup.
                 */
                do {
-                       unsigned int flags;
+                       gfp_t flags;
 
                        /* While we can still reduce the allocation size, don't
                         * raise a warning and allow the allocation to fail.