]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mtd: rawnand: tango: fix probe function error path
authorMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 21 Mar 2018 13:01:53 +0000 (14:01 +0100)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Thu, 29 Mar 2018 07:38:20 +0000 (09:38 +0200)
An error after nand_scan_tail() should trigger a nand_cleanup().
The helper mtd_device_parse_register() returns an error code that should
be checked and nand_cleanup() called accordingly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/mtd/nand/raw/tango_nand.c

index c5bee00b7f5e321cb83e35d1056d2c8295eb2aaa..f54518ffb36af43221bc01905a731d3c9e73d968 100644 (file)
@@ -591,8 +591,10 @@ static int chip_init(struct device *dev, struct device_node *np)
        tchip->bb_cfg = BB_CFG(mtd->writesize, BBM_SIZE);
 
        err = mtd_device_register(mtd, NULL, 0);
-       if (err)
+       if (err) {
+               nand_cleanup(chip);
                return err;
+       }
 
        nfc->chips[cs] = tchip;