]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dmaengine: xilinx_dma: Merge get_callback and _invoke
authorNicholas Graumann <nick.graumann@gmail.com>
Tue, 15 Oct 2019 14:48:19 +0000 (20:18 +0530)
committerVinod Koul <vkoul@kernel.org>
Sun, 20 Oct 2019 14:05:27 +0000 (19:35 +0530)
The dma api provides a single interface to get the appropriate callback
and invoke it directly. Prefer using it.

Signed-off-by: Nicholas Graumann <nick.graumann@gmail.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Link: https://lore.kernel.org/r/1571150904-3988-3-git-send-email-radhey.shyam.pandey@xilinx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/xilinx/xilinx_dma.c

index 3e690ec45c1348cee1d861c2fd98845e99142272..87132bd8cd36ca43d59407b2329b00b2cdb2c1eb 100644 (file)
@@ -820,8 +820,6 @@ static void xilinx_dma_chan_desc_cleanup(struct xilinx_dma_chan *chan)
        spin_lock_irqsave(&chan->lock, flags);
 
        list_for_each_entry_safe(desc, next, &chan->done_list, node) {
-               struct dmaengine_desc_callback cb;
-
                if (desc->cyclic) {
                        xilinx_dma_chan_handle_cyclic(chan, desc, &flags);
                        break;
@@ -831,9 +829,8 @@ static void xilinx_dma_chan_desc_cleanup(struct xilinx_dma_chan *chan)
                list_del(&desc->node);
 
                /* Run the link descriptor callback function */
-               dmaengine_desc_get_callback(&desc->async_tx, &cb);
                spin_unlock_irqrestore(&chan->lock, flags);
-               dmaengine_desc_callback_invoke(&cb, NULL);
+               dmaengine_desc_get_callback_invoke(&desc->async_tx, NULL);
                spin_lock_irqsave(&chan->lock, flags);
 
                /* Run any dependencies, then free the descriptor */