]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gpio: mmio: remove untrue leftover comment
authorMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Wed, 13 Nov 2019 08:43:52 +0000 (10:43 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Wed, 13 Nov 2019 12:49:42 +0000 (13:49 +0100)
The comment should have been removed when new GPIO direction
definitions were taken in use as the function logic was changed. It
is now perfectly valid and Ok to hit the return from the bottom of
the direction getting function.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-mmio.c

index cd07c948649feac6af3b9f6d0cffbb4aaf7ec0cb..f729e3e9e983786d42fa5b96e809587e032326d5 100644 (file)
@@ -386,7 +386,6 @@ static int bgpio_get_dir(struct gpio_chip *gc, unsigned int gpio)
                if (!(gc->read_reg(gc->reg_dir_in) & bgpio_line2mask(gc, gpio)))
                        return GPIO_LINE_DIRECTION_OUT;
 
-       /* This should not happen */
        return GPIO_LINE_DIRECTION_IN;
 }