]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
efi: include asm/early_ioremap.h not asm/efi.h to get early_memremap
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 12 Jan 2016 13:22:46 +0000 (14:22 +0100)
committerTony Luck <tony.luck@intel.com>
Wed, 13 Jan 2016 18:35:14 +0000 (10:35 -0800)
The code in efi.c uses early_memremap(), but relies on a transitive
include rather than including asm/early_ioremap.h directly, since
this header did not exist on ia64.

Commit f7d924894265 ("arm64/efi: refactor EFI init and runtime code
for reuse by 32-bit ARM") attempted to work around this by including
asm/efi.h, which transitively includes asm/early_ioremap.h on most
architectures. However, since asm/efi.h does not exist on ia64 either,
this is not much of an improvement.

Now that we have created an asm/early_ioremap.h for ia64, we can just
include it directly.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>
drivers/firmware/efi/efi.c

index cffa89b3317b59f0194c01e1caaafe52bb3496bc..2cd37dad67a63645b15d9f2f496630a1e820ce19 100644 (file)
@@ -25,7 +25,7 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 
-#include <asm/efi.h>
+#include <asm/early_ioremap.h>
 
 struct efi __read_mostly efi = {
        .mps                    = EFI_INVALID_TABLE_ADDR,