]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: i2c: adv748x: Restore full DT paths in kernel messages
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 28 Nov 2017 13:01:24 +0000 (08:01 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 8 Dec 2017 16:27:46 +0000 (11:27 -0500)
As of_node_full_name() now returns only the basename, the endpoint
information printed became useless:

    adv748x 4-0070: Endpoint endpoint on port 7
    adv748x 4-0070: Endpoint endpoint on port 8
    adv748x 4-0070: Endpoint endpoint on port 10
    adv748x 4-0070: Endpoint endpoint on port 11

Restore the old behavior by using "%pOF" instead:

    adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@7/endpoint on port 7
    adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@8/endpoint on port 8
    adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@10/endpoint on port 10
    adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@11/endpoint on port 11

Fixes: a7e4cfb0a7ca4773 ("of/fdt: only store the device node basename in full_name")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/adv748x/adv748x-core.c

index 10c3d469175c4f2079058a90a542596b591d3ecc..fd92c9e4b519d2c56305e1ebeb9b8118ee868520 100644 (file)
@@ -644,14 +644,12 @@ static int adv748x_parse_dt(struct adv748x_state *state)
 
        for_each_endpoint_of_node(state->dev->of_node, ep_np) {
                of_graph_parse_endpoint(ep_np, &ep);
-               adv_info(state, "Endpoint %s on port %d",
-                               of_node_full_name(ep.local_node),
-                               ep.port);
+               adv_info(state, "Endpoint %pOF on port %d", ep.local_node,
+                        ep.port);
 
                if (ep.port >= ADV748X_PORT_MAX) {
-                       adv_err(state, "Invalid endpoint %s on port %d",
-                               of_node_full_name(ep.local_node),
-                               ep.port);
+                       adv_err(state, "Invalid endpoint %pOF on port %d",
+                               ep.local_node, ep.port);
 
                        continue;
                }