]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
fscrypt: remove CRYPTO_CTR dependency
authorEric Biggers <ebiggers@google.com>
Wed, 5 Sep 2018 19:24:00 +0000 (12:24 -0700)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 24 Jan 2019 04:56:43 +0000 (23:56 -0500)
fscrypt doesn't use the CTR mode of operation for anything, so there's
no need to select CRYPTO_CTR.  It was added by commit 71dea01ea2ed
("ext4 crypto: require CONFIG_CRYPTO_CTR if ext4 encryption is
enabled").  But, I've been unable to identify the arm64 crypto bug it
was supposedly working around.

I suspect the issue was seen only on some old Android device kernel
(circa 3.10?).  So if the fix wasn't mistaken, the real bug is probably
already fixed.  Or maybe it was actually a bug in a non-upstream crypto
driver.

So, remove the dependency.  If it turns out there's actually still a
bug, we'll fix it properly.

Signed-off-by: Eric Biggers <ebiggers@google.com>
fs/crypto/Kconfig

index 02b7d91c923109309be54d9b4bbc6c925863adcf..284b589b4774d5db8965cbb870118313a707d1ad 100644 (file)
@@ -6,7 +6,6 @@ config FS_ENCRYPTION
        select CRYPTO_ECB
        select CRYPTO_XTS
        select CRYPTO_CTS
-       select CRYPTO_CTR
        select CRYPTO_SHA256
        select KEYS
        help