]> asedeno.scripts.mit.edu Git - PuTTY.git/commitdiff
Fix a null-dereference introduced by another mis-fix in r9919.
authorSimon Tatham <anakin@pobox.com>
Sat, 20 Jul 2013 13:15:20 +0000 (13:15 +0000)
committerSimon Tatham <anakin@pobox.com>
Sat, 20 Jul 2013 13:15:20 +0000 (13:15 +0000)
[originally from svn r9946]
[r9919 == ea301bdd9b892a5e70692f82f5c0b98bd585e775]

import.c

index f6dc2809a28c6aed884a293e67f66ac38cf685bb..bc35a4ab7d08b5aebb64332e7d0b84dad2f50bb2 100644 (file)
--- a/import.c
+++ b/import.c
@@ -1247,11 +1247,15 @@ int sshcom_encrypted(const Filename *filename, char **comment)
         answer = 1;
 
     done:
-    *comment = dupstr(key ? key->comment : "");
-    smemclr(key->keyblob, key->keyblob_size);
-    sfree(key->keyblob);
-    smemclr(key, sizeof(*key));
-    sfree(key);
+    if (key) {
+        *comment = dupstr(key->comment);
+        smemclr(key->keyblob, key->keyblob_size);
+        sfree(key->keyblob);
+        smemclr(key, sizeof(*key));
+        sfree(key);
+    } else {
+        *comment = dupstr("");
+    }
     return answer;
 }