]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: phy: sfp: clean up a condition
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 13 Jun 2019 06:51:02 +0000 (09:51 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 15 Jun 2019 02:21:31 +0000 (19:21 -0700)
The acpi_node_get_property_reference() doesn't return ACPI error codes,
it just returns regular negative kernel error codes.  This patch doesn't
affect run time, it's just a clean up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ruslan Babayev <ruslan@babayev.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/sfp.c

index 97960d73b4ab5f49875b0a539ed3a4ab764d1db6..2d816aadea79501cbdde69db3056fffc56c20486 100644 (file)
@@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
                int ret;
 
                ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
-               if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
+               if (ret || !is_acpi_device_node(args.fwnode)) {
                        dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
                        return -ENODEV;
                }