]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: qla2xxx: Make qla2x00_sysfs_write_nvram() easier to analyze
authorBart Van Assche <bvanassche@acm.org>
Thu, 18 Oct 2018 22:45:43 +0000 (15:45 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 24 Oct 2018 01:32:34 +0000 (21:32 -0400)
Modify the unlock statement such that it becomes easier for static
analyzers to analyze it. This patch does not change any functionality.

Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_attr.c

index b28f159fdaee79fe194be3cddc81e1842059e104..0bb9ac6ece9205b8f652fa55a7f752b780012ff5 100644 (file)
@@ -218,7 +218,7 @@ qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj,
 
        mutex_lock(&ha->optrom_mutex);
        if (qla2x00_chip_is_down(vha)) {
-               mutex_unlock(&vha->hw->optrom_mutex);
+               mutex_unlock(&ha->optrom_mutex);
                return -EAGAIN;
        }