]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: iio: adt7316: allow adt751x to use internal vref for all dacs
authorJeremy Fertic <jeremyfertic@gmail.com>
Wed, 12 Dec 2018 00:55:00 +0000 (17:55 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 16 Dec 2018 14:05:55 +0000 (14:05 +0000)
With adt7516/7/9, internal vref is available for dacs a and b, dacs c and
d, or all dacs. The driver doesn't currently support internal vref for all
dacs. Change the else if to an if so both bits are checked rather than
just one or the other.

Signed-off-by: Jeremy Fertic <jeremyfertic@gmail.com>
Fixes: 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9 driver")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/addac/adt7316.c

index c1050dc678cf807b1c0e16795bb4a860c5114e9c..ab6de60a94ae654088be006a6055d227f129ec44 100644 (file)
@@ -1086,7 +1086,7 @@ static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,
                ldac_config = chip->ldac_config & (~ADT7516_DAC_IN_VREF_MASK);
                if (data & 0x1)
                        ldac_config |= ADT7516_DAC_AB_IN_VREF;
-               else if (data & 0x2)
+               if (data & 0x2)
                        ldac_config |= ADT7516_DAC_CD_IN_VREF;
        } else {
                ret = kstrtou8(buf, 16, &data);