Yikes! Forgot to zero the password after SSH2 PW authentication.

[originally from svn r2512]

diff --git a/ssh.c b/ssh.c
index 24617b1c28c7701c3d97f355322eeae5af86ba1a..eac31128450cf38d8cb338c79a026c808fcb24e7 100644 (file)
--- a/ssh.c
+++ b/ssh.c
@@ -4942,6 +4942,7 @@ static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                ssh2_pkt_addstring(ssh, "password");
                ssh2_pkt_addbool(ssh, FALSE);
                ssh2_pkt_addstring(ssh, s->password);
+               memset(s->password, 0, sizeof(s->password));
                ssh2_pkt_defer(ssh);
                /*
                 * We'll include a string that's an exact multiple of the