]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: mvm: make iwl_dump_prph() void
authorJohannes Berg <johannes.berg@intel.com>
Thu, 20 Oct 2016 07:44:05 +0000 (09:44 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Mon, 23 Jan 2017 21:36:56 +0000 (23:36 +0200)
The return value is never used, so make the function void.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c

index 46ab6b9f680bf03e666d4d9a854120aec6811ca8..7df3c3f4749e80f1cc734b83c17aa0777336e103 100644 (file)
@@ -406,17 +406,17 @@ static const struct iwl_prph_range iwl_prph_dump_addr_9000[] = {
        { .start = 0x00a02400, .end = 0x00a02758 },
 };
 
-static u32 iwl_dump_prph(struct iwl_trans *trans,
-                        struct iwl_fw_error_dump_data **data,
-                        const struct iwl_prph_range *iwl_prph_dump_addr,
-                        u32 range_len)
+static void iwl_dump_prph(struct iwl_trans *trans,
+                         struct iwl_fw_error_dump_data **data,
+                         const struct iwl_prph_range *iwl_prph_dump_addr,
+                         u32 range_len)
 {
        struct iwl_fw_error_dump_prph *prph;
        unsigned long flags;
-       u32 prph_len = 0, i;
+       u32 i;
 
        if (!iwl_trans_grab_nic_access(trans, &flags))
-               return 0;
+               return;
 
        for (i = 0; i < range_len; i++) {
                /* The range includes both boundaries */
@@ -425,8 +425,6 @@ static u32 iwl_dump_prph(struct iwl_trans *trans,
                int reg;
                __le32 *val;
 
-               prph_len += sizeof(**data) + sizeof(*prph) + num_bytes_in_chunk;
-
                (*data)->type = cpu_to_le32(IWL_FW_ERROR_DUMP_PRPH);
                (*data)->len = cpu_to_le32(sizeof(*prph) +
                                        num_bytes_in_chunk);
@@ -444,8 +442,6 @@ static u32 iwl_dump_prph(struct iwl_trans *trans,
        }
 
        iwl_trans_release_nic_access(trans, &flags);
-
-       return prph_len;
 }
 
 /*