]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
clk: imx6ul: fix missing of_node_put()
authorNicholas Mc Guire <hofrat@osadl.org>
Fri, 13 Jul 2018 11:13:20 +0000 (13:13 +0200)
committerStephen Boyd <sboyd@kernel.org>
Wed, 25 Jul 2018 20:34:57 +0000 (13:34 -0700)
of_find_compatible_node() is returning a device node with refcount
incremented and must be explicitly decremented after the last use
which is right after the us in of_iomap() here.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 787b4271a6a0 ("clk: imx: add imx6ul clk tree support")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/imx/clk-imx6ul.c

index ba563ba50b4035d8f09b5a40d66d1ba0977aeaf7..9f1a40498642c25e666f9718ad1b6ce11ef083c1 100644 (file)
@@ -142,6 +142,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
 
        np = of_find_compatible_node(NULL, NULL, "fsl,imx6ul-anatop");
        base = of_iomap(np, 0);
+       of_node_put(np);
        WARN_ON(!base);
 
        clks[IMX6UL_PLL1_BYPASS_SRC] = imx_clk_mux("pll1_bypass_src", base + 0x00, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels));