]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
percpu: resolve err may not be initialized in pcpu_alloc
authorDennis Zhou <dennisz@fb.com>
Wed, 21 Jun 2017 15:51:09 +0000 (11:51 -0400)
committerTejun Heo <tj@kernel.org>
Wed, 21 Jun 2017 16:00:45 +0000 (12:00 -0400)
From 4a42ecc735cff0015cc73c3d87edede631f4b885 Mon Sep 17 00:00:00 2001
From: Dennis Zhou <dennisz@fb.com>
Date: Wed, 21 Jun 2017 08:07:15 -0700

Add error message to out of space failure for atomic allocations in
percpu allocation path to fix -Wmaybe-uninitialized.

Signed-off-by: Dennis Zhou <dennisz@fb.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Tejun Heo <tj@kernel.org>
mm/percpu.c

index a5bc3634d2a90147a94934b225b2aa89be7d882e..bd4130a69bbc9b6b631baf911e66aab31f08b6e0 100644 (file)
@@ -956,8 +956,10 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved,
         * tasks to create chunks simultaneously.  Serialize and create iff
         * there's still no empty chunk after grabbing the mutex.
         */
-       if (is_atomic)
+       if (is_atomic) {
+               err = "atomic alloc failed, no space left";
                goto fail;
+       }
 
        if (list_empty(&pcpu_slot[pcpu_nr_slots - 1])) {
                chunk = pcpu_create_chunk();