]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ipmi_ssif: Fix uninitialized variable issue
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 19 Apr 2018 13:24:29 +0000 (08:24 -0500)
committerCorey Minyard <cminyard@mvista.com>
Thu, 19 Apr 2018 13:37:58 +0000 (08:37 -0500)
Currently, function ssif_remove returns _rv_, which is a variable that
is never initialized.

Fix this by removing variable _rv_ and return 0 instead.

Addresses-Coverity-ID: 1467999 ("Uninitialized scalar variable")
Fixes: 6a0d23ed338e ("ipmi: ipmi_unregister_smi() cannot fail, have it
return void")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_ssif.c

index ecabfe27c8288af0aaa6249bf95d0c58db89540e..37f9ae2de6a4ec1e7c96efbb38430777d321f258 100644 (file)
@@ -1227,7 +1227,6 @@ static int ssif_remove(struct i2c_client *client)
        struct ssif_info *ssif_info = i2c_get_clientdata(client);
        struct ipmi_smi *intf;
        struct ssif_addr_info *addr_info;
-       int rv;
 
        if (!ssif_info)
                return 0;
@@ -1247,7 +1246,7 @@ static int ssif_remove(struct i2c_client *client)
                }
        }
 
-       return rv;
+       return 0;
 }
 
 static int do_cmd(struct i2c_client *client, int len, unsigned char *msg,