]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
btrfs: remove superfluous BUG_ON() in integrity checks
authorJohannes Thumshirn <jth@kernel.org>
Thu, 5 Dec 2019 13:19:58 +0000 (14:19 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 20 Jan 2020 15:40:52 +0000 (16:40 +0100)
btrfsic_process_superblock() BUG_ON()s if 'state' is NULL. But this can
never happen as the only caller from btrfsic_process_superblock() is
btrfsic_mount() which allocates 'state' some lines above calling
btrfsic_process_superblock() and checks for the allocation to succeed.

Let's just remove the impossible to hit BUG_ON().

Signed-off-by: Johannes Thumshirn <jth@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/check-integrity.c

index 72c70f59fc605e8787d913b519e59c7d695f1e5b..a0ce69f2d27cd99cb3fe461305c933f91fbe90b1 100644 (file)
@@ -636,7 +636,6 @@ static int btrfsic_process_superblock(struct btrfsic_state *state,
        int ret = 0;
        int pass;
 
-       BUG_ON(NULL == state);
        selected_super = kzalloc(sizeof(*selected_super), GFP_NOFS);
        if (NULL == selected_super) {
                pr_info("btrfsic: error, kmalloc failed!\n");