]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
fpga: dfl: afu: Pass the correct device to dma_mapping_error()
authorScott Wood <swood@redhat.com>
Thu, 9 May 2019 21:08:27 +0000 (16:08 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 May 2019 18:32:12 +0000 (20:32 +0200)
dma_mapping_error() was being called on a different device struct than
what was passed to map/unmap.  Besides rendering the error checking
ineffective, it caused a debug splat with CONFIG_DMA_API_DEBUG.

Signed-off-by: Scott Wood <swood@redhat.com>
Acked-by: Wu Hao <hao.wu@intel.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/dfl-afu-dma-region.c

index c438722bf4e12f9c7f006f601f89b4ec72d08bd3..dcd80b088c7b37e8c8e1975f2b0a6a1190cd5f57 100644 (file)
@@ -399,7 +399,7 @@ int afu_dma_map_region(struct dfl_feature_platform_data *pdata,
                                    region->pages[0], 0,
                                    region->length,
                                    DMA_BIDIRECTIONAL);
-       if (dma_mapping_error(&pdata->dev->dev, region->iova)) {
+       if (dma_mapping_error(dfl_fpga_pdata_to_parent(pdata), region->iova)) {
                dev_err(&pdata->dev->dev, "failed to map for dma\n");
                ret = -EFAULT;
                goto unpin_pages;