]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: wilc1000: return kernel error codes from wilc_wlan_stop
authorAdham Abozaeid <adham.abozaeid@microchip.com>
Fri, 9 Aug 2019 18:25:19 +0000 (18:25 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Aug 2019 14:35:39 +0000 (16:35 +0200)
return -EIO for bus failures, 0 otherwise.

Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com>
Link: https://lore.kernel.org/r/20190809182510.22443-3-adham.abozaeid@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/wilc_wlan.c

index 3d902b499a3463340a50806b24a5d1706bc08574..2bbb359d21191a80feaff2111d286d15f16d3244 100644 (file)
@@ -979,7 +979,7 @@ int wilc_wlan_stop(struct wilc *wilc, struct wilc_vif *vif)
        if (!ret) {
                netdev_err(vif->ndev, "Error while reading reg\n");
                release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
-               return ret;
+               return -EIO;
        }
 
        ret = wilc->hif_func->hif_write_reg(wilc, WILC_GP_REG_0,
@@ -987,14 +987,14 @@ int wilc_wlan_stop(struct wilc *wilc, struct wilc_vif *vif)
        if (!ret) {
                netdev_err(vif->ndev, "Error while writing reg\n");
                release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
-               return ret;
+               return -EIO;
        }
 
        ret = wilc->hif_func->hif_read_reg(wilc, WILC_FW_HOST_COMM, &reg);
        if (!ret) {
                netdev_err(vif->ndev, "Error while reading reg\n");
                release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
-               return ret;
+               return -EIO;
        }
        reg = BIT(0);
 
@@ -1002,12 +1002,12 @@ int wilc_wlan_stop(struct wilc *wilc, struct wilc_vif *vif)
        if (!ret) {
                netdev_err(vif->ndev, "Error while writing reg\n");
                release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
-               return ret;
+               return -EIO;
        }
 
        release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
 
-       return ret;
+       return 0;
 }
 
 void wilc_wlan_cleanup(struct net_device *dev)