]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: i2c: mt9v032: fix enum mbus codes and frame sizes
authorEugen Hristev <eugen.hristev@microchip.com>
Thu, 21 Nov 2019 07:55:24 +0000 (08:55 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 4 Jan 2020 07:09:59 +0000 (08:09 +0100)
This driver supports both the mt9v032 (color) and the mt9v022 (mono)
sensors. Depending on which sensor is used, the format from the sensor is
different. The format.code inside the dev struct holds this information.
The enum mbus and enum frame sizes need to take into account both type of
sensors, not just the color one. To solve this, use the format.code in
these functions instead of the hardcoded bayer color format (which is only
used for mt9v032).

[Sakari Ailus: rewrapped commit message]

Suggested-by: Wenyou Yang <wenyou.yang@microchip.com>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/mt9v032.c

index 4b9b98cf6674c3924b41567bbc546a66c002f94e..5bd3ae82992f35b59339f8283471caed95c3d6c4 100644 (file)
@@ -428,10 +428,12 @@ static int mt9v032_enum_mbus_code(struct v4l2_subdev *subdev,
                                  struct v4l2_subdev_pad_config *cfg,
                                  struct v4l2_subdev_mbus_code_enum *code)
 {
+       struct mt9v032 *mt9v032 = to_mt9v032(subdev);
+
        if (code->index > 0)
                return -EINVAL;
 
-       code->code = MEDIA_BUS_FMT_SGRBG10_1X10;
+       code->code = mt9v032->format.code;
        return 0;
 }
 
@@ -439,7 +441,11 @@ static int mt9v032_enum_frame_size(struct v4l2_subdev *subdev,
                                   struct v4l2_subdev_pad_config *cfg,
                                   struct v4l2_subdev_frame_size_enum *fse)
 {
-       if (fse->index >= 3 || fse->code != MEDIA_BUS_FMT_SGRBG10_1X10)
+       struct mt9v032 *mt9v032 = to_mt9v032(subdev);
+
+       if (fse->index >= 3)
+               return -EINVAL;
+       if (mt9v032->format.code != fse->code)
                return -EINVAL;
 
        fse->min_width = MT9V032_WINDOW_WIDTH_DEF / (1 << fse->index);