]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mm/hmm: Do not use list*_rcu() for hmm->ranges
authorJason Gunthorpe <jgg@mellanox.com>
Thu, 23 May 2019 14:43:43 +0000 (11:43 -0300)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 18 Jun 2019 14:57:45 +0000 (11:57 -0300)
This list is always read and written while holding hmm->lock so there is
no need for the confusing _rcu annotations.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
Reviewed-by: Ira Weiny <iweiny@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Philip Yang <Philip.Yang@amd.com>
mm/hmm.c

index 0423f4ca3a7e09731667a00b17aab5b8bf1989ef..73c8af4827fe87ca521e4b9486e53df6ca0981a2 100644 (file)
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -912,7 +912,7 @@ int hmm_range_register(struct hmm_range *range,
 
        range->hmm = hmm;
        kref_get(&hmm->kref);
-       list_add_rcu(&range->list, &hmm->ranges);
+       list_add(&range->list, &hmm->ranges);
 
        /*
         * If there are any concurrent notifiers we have to wait for them for
@@ -942,7 +942,7 @@ void hmm_range_unregister(struct hmm_range *range)
                return;
 
        mutex_lock(&hmm->lock);
-       list_del_rcu(&range->list);
+       list_del(&range->list);
        mutex_unlock(&hmm->lock);
 
        /* Drop reference taken by hmm_range_register() */