]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
macintosh: windfarm: Another convert to using %pOFn instead of device_node.name
authorRob Herring <robh@kernel.org>
Fri, 16 Nov 2018 22:05:39 +0000 (16:05 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 26 Nov 2018 11:33:37 +0000 (22:33 +1100)
In preparation to remove the node name pointer from struct
device_node, convert printf users to use the %pOFn format specifier.

Convert the open coded iterating thru child nodes to
for_each_child_of_node() while we're here.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/macintosh/windfarm_fcu_controls.c

index fab7a21e95776f4d1074b877b710f31d551705ef..2b3ca628a6504d5355a44c875c5f53139a19ccb8 100644 (file)
@@ -425,18 +425,18 @@ static void wf_fcu_lookup_fans(struct wf_fcu_priv *pv)
                { "CPU B 2",            "cpu-fan-b-1",          },
                { "CPU B 3",            "cpu-fan-c-1",          },
        };
-       struct device_node *np = NULL, *fcu = pv->i2c->dev.of_node;
+       struct device_node *np, *fcu = pv->i2c->dev.of_node;
        int i;
 
        DBG("Looking up FCU controls in device-tree...\n");
 
-       while ((np = of_get_next_child(fcu, np)) != NULL) {
+       for_each_child_of_node(fcu, np) {
                int id, type = -1;
                const char *loc;
                const char *name;
                const u32 *reg;
 
-               DBG(" control: %s, type: %s\n", np->name, np->type);
+               DBG(" control: %pOFn, type: %s\n", np, of_node_get_device_type(np));
 
                /* Detect control type */
                if (!strcmp(np->type, "fan-rpm-control") ||