]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: ibmvscsi: log bad SRP response opcode in hex format
authorTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Wed, 7 Dec 2016 22:04:36 +0000 (16:04 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 8 Dec 2016 22:03:04 +0000 (17:03 -0500)
An unrecogonized or unsupported SRP response has its opcode currently
logged in decimal format. Log it in hex format instead so it can easily
be validated against the SRP specs values which are in hex.

Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ibmvscsi/ibmvscsi.c

index a0ee16f56f58e3fb4e9134d062385e1c2742a45d..7752656c3d2151b634a89d186846dd8dc4bd3225 100644 (file)
@@ -993,7 +993,7 @@ static void handle_cmd_rsp(struct srp_event_struct *evt_struct)
        if (unlikely(rsp->opcode != SRP_RSP)) {
                if (printk_ratelimit())
                        dev_warn(evt_struct->hostdata->dev,
-                                "bad SRP RSP type %d\n", rsp->opcode);
+                                "bad SRP RSP type %#02x\n", rsp->opcode);
        }
        
        if (cmnd) {