]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
perf mem: Fix display of data source snoop indication
authorAndi Kleen <ak@linux.intel.com>
Wed, 19 Apr 2017 17:49:40 +0000 (10:49 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 24 Apr 2017 15:33:32 +0000 (12:33 -0300)
'perf mem report' doesn't display the data source snoop indication correctly.

In the kernel API the definition is:

  #define PERF_MEM_SNOOP_NONE     0x02 /* no snoop */
  #define PERF_MEM_SNOOP_HIT      0x04 /* snoop hit */
  #define PERF_MEM_SNOOP_MISS     0x08 /* snoop miss */

but the table used by the perf tools exchanged "Hit" and "Miss":

        "None",
        "Miss",
        "Hit",

Fix the table in perf.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20170419174940.13641-1-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/mem-events.c

index c56d52f90b54b064f9ed62957be9b3a1c9b777fe..06f5a3a4295c52cac138ac2526afdac04ffbf0dc 100644 (file)
@@ -206,8 +206,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
 static const char * const snoop_access[] = {
        "N/A",
        "None",
-       "Miss",
        "Hit",
+       "Miss",
        "HitM",
 };