netvsc: propagate MAC address change to VF slave

If VF is slaved to synthetic device, then any change to netvsc
MAC address should be propagated to the slave device.

If slave device doesn't support MAC address change then it
should also be an error to attempt to change synthetic NIC MAC
address.

It also fixes the error unwind in the original code.
If give a bad address, the old code would change the device
MAC address anyway.

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index e059375a6d8cd801fe4ff1e6bf6858bb5ba6be64..07015b1c42c6300b9a47e415c5a595fdc693cc75 100644 (file)
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -1053,27 +1053,31 @@ static void netvsc_get_stats64(struct net_device *net,
 static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
 {
        struct net_device_context *ndc = netdev_priv(ndev);
+       struct net_device *vf_netdev = rtnl_dereference(ndc->vf_netdev);
        struct netvsc_device *nvdev = rtnl_dereference(ndc->nvdev);
        struct sockaddr *addr = p;
-       char save_adr[ETH_ALEN];
-       unsigned char save_aatype;
        int err;
 
-       memcpy(save_adr, ndev->dev_addr, ETH_ALEN);
-       save_aatype = ndev->addr_assign_type;
-
-       err = eth_mac_addr(ndev, p);
-       if (err != 0)
+       err = eth_prepare_mac_addr_change(ndev, p);
+       if (err)
                return err;
 
        if (!nvdev)
                return -ENODEV;
 
+       if (vf_netdev) {
+               err = dev_set_mac_address(vf_netdev, addr);
+               if (err)
+                       return err;
+       }
+
        err = rndis_filter_set_device_mac(nvdev, addr->sa_data);
-       if (err != 0) {
-               /* roll back to saved MAC */
-               memcpy(ndev->dev_addr, save_adr, ETH_ALEN);
-               ndev->addr_assign_type = save_aatype;
+       if (!err) {
+               eth_commit_mac_addr_change(ndev, p);
+       } else if (vf_netdev) {
+               /* rollback change on VF */
+               memcpy(addr->sa_data, ndev->dev_addr, ETH_ALEN);
+               dev_set_mac_address(vf_netdev, addr);
        }
 
        return err;