]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl: intel: Remove default Interrupt Status offset
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 23 Jul 2019 15:56:33 +0000 (18:56 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 7 Aug 2019 14:25:19 +0000 (17:25 +0300)
Since some of the GPIO controllers use different Interrupt Status offset,
it make sense to provide it explicitly in the drivers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/pinctrl/intel/pinctrl-intel.c
drivers/pinctrl/intel/pinctrl-intel.h

index 913c5dae773c986fbe2851a6b0ca551b3d1b2afd..5c7348caac36d36726c80ba468226391a557376c 100644 (file)
@@ -29,7 +29,6 @@
 #define REVID_MASK                     GENMASK(31, 16)
 
 #define PADBAR                         0x00c
-#define GPI_IS                         0x100
 
 #define PADOWN_BITS                    4
 #define PADOWN_SHIFT(p)                        ((p) % 8 * PADOWN_BITS)
@@ -1342,9 +1341,6 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
                community->regs = regs;
                community->pad_regs = regs + padbar;
 
-               if (!community->is_offset)
-                       community->is_offset = GPI_IS;
-
                ret = intel_pinctrl_add_padgroups(pctrl, community);
                if (ret)
                        return ret;
index a8e958f1dcf5a6252200ad1af49e0360be85ef50..f0234ca154a077b50d031982ac522cfb41f980ff 100644 (file)
@@ -75,8 +75,7 @@ struct intel_padgroup {
  * @hostown_offset: Register offset of HOSTSW_OWN from @regs. If %0 then it
  *                  is assumed that the host owns the pin (rather than
  *                  ACPI).
- * @is_offset: Register offset of GPI_IS from @regs. If %0 then uses the
- *             default (%0x100).
+ * @is_offset: Register offset of GPI_IS from @regs.
  * @ie_offset: Register offset of GPI_IE from @regs.
  * @pin_base: Starting pin of pins in this community
  * @gpp_size: Maximum number of pads in each group, such as PADCFGLOCK,