]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: ufs: Release clock if DMA map fails
authorCan Guo <cang@codeaurora.org>
Thu, 5 Dec 2019 02:14:33 +0000 (02:14 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 Dec 2019 03:08:53 +0000 (22:08 -0500)
In queuecommand path, if DMA map fails, it bails out with clock held.  In
this case, release the clock to keep its usage paired.

[mkp: applied by hand]

Link: https://lore.kernel.org/r/0101016ed3d66395-1b7e7fce-b74d-42ca-a88a-4db78b795d3b-000000@us-west-2.amazonses.com
Reviewed-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 0aa42b68dab6ebb786aabd5eb446cf2615723ad1..64abb30d990a40cc7c72389164007bbfb69a61e3 100644 (file)
@@ -2450,6 +2450,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
        err = ufshcd_map_sg(hba, lrbp);
        if (err) {
                lrbp->cmd = NULL;
+               ufshcd_release(hba);
                goto out;
        }
        /* Make sure descriptors are ready before ringing the doorbell */