]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
regulator: act8865: fix ptr_ret.cocci warnings
authorkbuild test robot <lkp@intel.com>
Wed, 24 Jul 2019 09:22:36 +0000 (17:22 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 25 Jul 2019 16:44:11 +0000 (17:44 +0100)
drivers/regulator/act8865-regulator.c:447:8-14: WARNING: PTR_ERR_OR_ZERO can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 2d09a79bf637 ("regulator: act8865: Add support for act8600 charger")
CC: Maarten ter Huurne <maarten@treewalker.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20190724092236.witxtfmubun25l2t@1905cc33b6dd
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/act8865-regulator.c

index b515e0785d67f09e4a639f7ed80ea0bbe3239d3f..6a90d3c7a452038c926c0db86fb438fccfc7bd80 100644 (file)
@@ -465,7 +465,7 @@ static int act8600_charger_probe(struct device *dev, struct regmap *regmap)
 
        charger = devm_power_supply_register(dev, &act8600_charger_desc, &cfg);
 
-       return IS_ERR(charger) ? PTR_ERR(charger) : 0;
+       return PTR_ERR_OR_ZERO(charger);
 }
 
 static int act8865_pmic_probe(struct i2c_client *client,