]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ext2: Delete an unnecessary check before brelse()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 3 Sep 2019 12:40:18 +0000 (14:40 +0200)
committerJan Kara <jack@suse.cz>
Wed, 4 Sep 2019 16:19:43 +0000 (18:19 +0200)
The brelse() function tests whether its argument is NULL
and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/51dea296-2207-ebc0-bac3-13f3e5c3b235@web.de
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext2/super.c

index 44eb6e7eb492f2fc302cbe0652fd83269e7d2950..f4d5c624c4dc45aa91d4baaf60ff5229a73ef2a1 100644 (file)
@@ -162,8 +162,7 @@ static void ext2_put_super (struct super_block * sb)
        }
        db_count = sbi->s_gdb_count;
        for (i = 0; i < db_count; i++)
-               if (sbi->s_group_desc[i])
-                       brelse (sbi->s_group_desc[i]);
+               brelse(sbi->s_group_desc[i]);
        kfree(sbi->s_group_desc);
        kfree(sbi->s_debts);
        percpu_counter_destroy(&sbi->s_freeblocks_counter);