]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: rc: Use devm_platform_ioremap_resource() in tango_ir_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 18 Sep 2019 10:30:18 +0000 (07:30 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 7 Oct 2019 10:44:56 +0000 (07:44 -0300)
Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/rc/tango-ir.c

index 451ec4e9dcfa1f6ace6e7fc6979c4910205c49d6..b8eb5bc4d9be17afdc0af4da791c327cf1ece4d8 100644 (file)
@@ -157,20 +157,10 @@ static int tango_ir_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct rc_dev *rc;
        struct tango_ir *ir;
-       struct resource *rc5_res;
-       struct resource *rc6_res;
        u64 clkrate, clkdiv;
        int irq, err;
        u32 val;
 
-       rc5_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!rc5_res)
-               return -EINVAL;
-
-       rc6_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       if (!rc6_res)
-               return -EINVAL;
-
        irq = platform_get_irq(pdev, 0);
        if (irq <= 0)
                return -EINVAL;
@@ -179,11 +169,11 @@ static int tango_ir_probe(struct platform_device *pdev)
        if (!ir)
                return -ENOMEM;
 
-       ir->rc5_base = devm_ioremap_resource(dev, rc5_res);
+       ir->rc5_base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ir->rc5_base))
                return PTR_ERR(ir->rc5_base);
 
-       ir->rc6_base = devm_ioremap_resource(dev, rc6_res);
+       ir->rc6_base = devm_platform_ioremap_resource(pdev, 1);
        if (IS_ERR(ir->rc6_base))
                return PTR_ERR(ir->rc6_base);