]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: s5p-jpeg: Correct step and max values for V4L2_CID_JPEG_RESTART_INTERVAL
authorPawe? Chmiel <pawel.mikolaj.chmiel@gmail.com>
Wed, 9 Jan 2019 18:00:41 +0000 (13:00 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 16 Jan 2019 17:39:11 +0000 (12:39 -0500)
This commit corrects max and step values for v4l2 control for
V4L2_CID_JPEG_RESTART_INTERVAL. Max should be 0xffff and step should be 1.
It was found by using v4l2-compliance tool and checking result of
VIDIOC_QUERY_EXT_CTRL/QUERYMENU test.
Previously it was complaining that step was bigger than difference
between max and min.

Fixes: 15f4bc3b1f42 ("[media] s5p-jpeg: Add JPEG controls support")
Signed-off-by: Pawe? Chmiel <pawel.mikolaj.chmiel@gmail.com>
Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/s5p-jpeg/jpeg-core.c

index 85110766043fd24ac016089ca49932be109d06b0..0a23b2d19e14add694c7a780179448760282597e 100644 (file)
@@ -2005,7 +2005,7 @@ static int s5p_jpeg_controls_create(struct s5p_jpeg_ctx *ctx)
 
                v4l2_ctrl_new_std(&ctx->ctrl_handler, &s5p_jpeg_ctrl_ops,
                                  V4L2_CID_JPEG_RESTART_INTERVAL,
-                                 0, 3, 0xffff, 0);
+                                 0, 0xffff, 1, 0);
                if (ctx->jpeg->variant->version == SJPEG_S5P)
                        mask = ~0x06; /* 422, 420 */
        }