]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: mvm: avoid sending too many BARs
authorSara Sharon <sara.sharon@intel.com>
Tue, 1 May 2018 12:12:08 +0000 (15:12 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 31 Aug 2018 08:38:32 +0000 (11:38 +0300)
When we receive TX response, we may release a few packets
due to a hole that was closed in the transmission window.

However, if that frame failed, we will mark all the released
frames as failed and will send multiple BARs.

This affects statistics badly, and cause unnecessary frames
transmission.

Instead, mark all the following packets as success, with the
desired result of sending a bar for the failed frame only.

Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/tx.c

index 31a81a4c6e78bd79020d7f69b1696e76475887e3..b33b8357a8f79729dc29c238a792086ea5961a8c 100644 (file)
@@ -1510,6 +1510,14 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm *mvm,
                        break;
                }
 
+               /*
+                * If we are freeing multiple frames, mark all the frames
+                * but the first one as acked, since they were acknowledged
+                * before
+                * */
+               if (skb_freed > 1)
+                       info->flags |= IEEE80211_TX_STAT_ACK;
+
                iwl_mvm_tx_status_check_trigger(mvm, status);
 
                info->status.rates[0].count = tx_resp->failure_frame + 1;