]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
driver: uio: fix possible memory leak in __uio_register_device
authorLiu Jian <liujian56@huawei.com>
Tue, 22 Jan 2019 22:45:37 +0000 (06:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 31 Jan 2019 15:36:36 +0000 (16:36 +0100)
'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.

Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio.c

index effe72834c2f0ed7ebda0c6c1d44eed526e5191f..f23ef235359f7398a4e2e4b1c5f077a09c11b879 100644 (file)
@@ -940,8 +940,10 @@ int __uio_register_device(struct module *owner,
        atomic_set(&idev->event, 0);
 
        ret = uio_get_minor(idev);
-       if (ret)
+       if (ret) {
+               kfree(idev);
                return ret;
+       }
 
        idev->dev.devt = MKDEV(uio_major, idev->minor);
        idev->dev.class = &uio_class;