]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
greybus: core: fix hd-creation error path
authorJohan Hovold <johan@hovoldconsulting.com>
Wed, 2 Sep 2015 15:37:38 +0000 (17:37 +0200)
committerJohan Hovold <johan@hovoldconsulting.com>
Thu, 3 Sep 2015 07:43:46 +0000 (09:43 +0200)
Make sure to return an errno when a host-device buffer-size check fails.

Fixes: 1f92f6404614 ("core: return error code when creating host device")
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/staging/greybus/core.c

index 3ba744b0e99884989af98e5110d022c1e5cd7c4c..605a0887dc61f1d929433fb7ffcf3abeac72091d 100644 (file)
@@ -184,7 +184,7 @@ struct greybus_host_device *greybus_create_hd(struct greybus_host_driver *driver
 
        if (buffer_size_max < GB_OPERATION_MESSAGE_SIZE_MIN) {
                dev_err(parent, "greybus host-device buffers too small\n");
-               return NULL;
+               return ERR_PTR(-EINVAL);
        }
 
        if (num_cports == 0 || num_cports > CPORT_ID_MAX) {