]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped
authorHans de Goede <hdegoede@redhat.com>
Wed, 14 Dec 2016 13:52:07 +0000 (14:52 +0100)
committerLee Jones <lee.jones@linaro.org>
Mon, 13 Feb 2017 09:29:41 +0000 (09:29 +0000)
The R in PEK_DBR stands for rising, so it should be mapped to
AXP288_IRQ_POKP where the last P stands for positive edge.

Likewise PEK_DBF should be mapped to the falling edge, aka the
_N_egative edge, so it should be mapped to AXP288_IRQ_POKN.

This fixes the inverted powerbutton status reporting by the
axp20x-pek driver.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/axp20x.c

index 89b2ee5a53463df76b73c86ccf5903e7fcbc998d..26ea174ba7cc0c8cd8a63c307cf71cfe0340aada 100644 (file)
@@ -207,14 +207,14 @@ static struct resource axp22x_pek_resources[] = {
 static struct resource axp288_power_button_resources[] = {
        {
                .name   = "PEK_DBR",
-               .start  = AXP288_IRQ_POKN,
-               .end    = AXP288_IRQ_POKN,
+               .start  = AXP288_IRQ_POKP,
+               .end    = AXP288_IRQ_POKP,
                .flags  = IORESOURCE_IRQ,
        },
        {
                .name   = "PEK_DBF",
-               .start  = AXP288_IRQ_POKP,
-               .end    = AXP288_IRQ_POKP,
+               .start  = AXP288_IRQ_POKN,
+               .end    = AXP288_IRQ_POKN,
                .flags  = IORESOURCE_IRQ,
        },
 };