]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
bnx2x: Collect the device debug information during Tx timeout.
authorSudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com>
Thu, 24 May 2018 11:57:51 +0000 (04:57 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 May 2018 02:52:52 +0000 (22:52 -0400)
Tx-timeout mostly happens due to some issue in the device. In such cases,
debug dump would be helpful for identifying the cause of the issue.
This patch adds support to spill debug data during the Tx timeout. Here
bnx2x_panic_dump() API is used instead of bnx2x_panic(), since we still
want to allow the Tx-timeout recovery a chance to succeed.

Changes from previous version:
-------------------------------
v2: Fixed a coding error.

Please consider applying this to "net-next".

Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c

index 95871576ab9251ff0b643471cfe0e11e3c3996d0..8cd73ff5debc276aec53d1f056fe3040875b2c0a 100644 (file)
@@ -4962,8 +4962,13 @@ void bnx2x_tx_timeout(struct net_device *dev)
 {
        struct bnx2x *bp = netdev_priv(dev);
 
-#ifdef BNX2X_STOP_ON_ERROR
+       /* We want the information of the dump logged,
+        * but calling bnx2x_panic() would kill all chances of recovery.
+        */
        if (!bp->panic)
+#ifndef BNX2X_STOP_ON_ERROR
+               bnx2x_panic_dump(bp, false);
+#else
                bnx2x_panic();
 #endif