]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: phy: dp83867: Use unsigned variables to store unsigned properties
authorTrent Piepho <tpiepho@impinj.com>
Wed, 22 May 2019 18:43:24 +0000 (18:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 May 2019 00:40:18 +0000 (17:40 -0700)
The variables used to store u32 DT properties were signed ints.  This
doesn't work properly if the value of the property were to overflow.
Use unsigned variables so this doesn't happen.

Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/dp83867.c

index fc5baa5d14d09d200b5598e4db9217ed0f1a2b98..59051b0f5be9132f84f8928cf65e67c66f0eed51 100644 (file)
@@ -93,9 +93,9 @@ enum {
 };
 
 struct dp83867_private {
-       int rx_id_delay;
-       int tx_id_delay;
-       int fifo_depth;
+       u32 rx_id_delay;
+       u32 tx_id_delay;
+       u32 fifo_depth;
        int io_impedance;
        int port_mirroring;
        bool rxctrl_strap_quirk;