]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: rtl8723bs: Compress two lines into one line
authorPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Sat, 30 Mar 2019 13:01:11 +0000 (18:31 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Mar 2019 18:58:20 +0000 (19:58 +0100)
Challenge suggested by coccinelle.

Return value directly without saving it in a variable and remove that
variable.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c

index 0fd7a9ae40cb007d5cad14c07318a62d320d7bd4..4f2ad54af398b9584898e3be3142e8b1982a74d2 100644 (file)
@@ -58,7 +58,7 @@ static        u32 phy_CalculateBitShift(u32 BitMask)
 */
 u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 RegAddr, u32 BitMask)
 {
-       u32 ReturnValue = 0, OriginalValue, BitShift;
+       u32 OriginalValue, BitShift;
 
 #if (DISABLE_BB_RF == 1)
        return 0;
@@ -68,9 +68,8 @@ u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 RegAddr, u32 BitMask)
 
        OriginalValue = rtw_read32(Adapter, RegAddr);
        BitShift = phy_CalculateBitShift(BitMask);
-       ReturnValue = (OriginalValue & BitMask) >> BitShift;
 
-       return ReturnValue;
+       return (OriginalValue & BitMask) >> BitShift;
 
 }
 
@@ -284,18 +283,16 @@ u32 PHY_QueryRFReg_8723B(
        u32 BitMask
 )
 {
-       u32 Original_Value, Readback_Value, BitShift;
+       u32 Original_Value, BitShift;
 
 #if (DISABLE_BB_RF == 1)
        return 0;
 #endif
 
        Original_Value = phy_RFSerialRead_8723B(Adapter, eRFPath, RegAddr);
-
        BitShift =  phy_CalculateBitShift(BitMask);
-       Readback_Value = (Original_Value & BitMask) >> BitShift;
 
-       return Readback_Value;
+       return (Original_Value & BitMask) >> BitShift;
 }
 
 /**