]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
HID: uclogic: remove redudant duplicated null check on ver_ptr
authorColin Ian King <colin.king@canonical.com>
Sat, 2 Mar 2019 22:23:38 +0000 (22:23 +0000)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Mon, 11 Mar 2019 13:43:14 +0000 (14:43 +0100)
Currently ver_ptr is being null checked twice, once before calling
usb_string and once afterwards.  The second null check is redundant
and can be removed, remove it.

Detected by CoverityScan, CID#1477308 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-uclogic-params.c

index 7710d9f957da5b0dd07ca1444416de7cecd10529..0187c9f8fc22c5567e934cc0cc2089877963c56e 100644 (file)
@@ -735,10 +735,6 @@ static int uclogic_params_huion_init(struct uclogic_params *params,
                goto cleanup;
        }
        rc = usb_string(udev, 201, ver_ptr, ver_len);
-       if (ver_ptr == NULL) {
-               rc = -ENOMEM;
-               goto cleanup;
-       }
        if (rc == -EPIPE) {
                *ver_ptr = '\0';
        } else if (rc < 0) {