]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: gasket: ioctl common: convert various logs to debug level
authorTodd Poynor <toddpoynor@google.com>
Sat, 21 Jul 2018 13:35:04 +0000 (06:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jul 2018 11:56:46 +0000 (13:56 +0200)
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_core.c
drivers/staging/gasket/gasket_ioctl.c

index 1d04fd0990e456d19ac1708f65276dc07f5f3b8f..732218773c3c6c5adf9b9579927c2fdbe9c7317c 100644 (file)
@@ -1801,7 +1801,7 @@ static long gasket_ioctl(struct file *filp, uint cmd, ulong arg)
                if (driver_desc->ioctl_handler_cb)
                        return driver_desc->ioctl_handler_cb(filp, cmd, argp);
 
-               gasket_log_error(
+               gasket_log_debug(
                        gasket_dev, "Received unknown ioctl 0x%x", cmd);
                return -EINVAL;
        }
index 8cf094b90cdb0748e738aa8e57ee78589f734b53..63e139ab7ff892bfee6562678d9764d411ea3596 100644 (file)
@@ -73,7 +73,7 @@ long gasket_handle_ioctl(struct file *filp, uint cmd, void __user *argp)
                }
        } else if (!gasket_ioctl_check_permissions(filp, cmd)) {
                trace_gasket_ioctl_exit(-EPERM);
-               gasket_log_error(gasket_dev, "ioctl cmd=%x noperm.", cmd);
+               gasket_log_debug(gasket_dev, "ioctl cmd=%x noperm.", cmd);
                return -EPERM;
        }
 
@@ -132,7 +132,7 @@ long gasket_handle_ioctl(struct file *filp, uint cmd, void __user *argp)
                 * the arg.
                 */
                trace_gasket_ioctl_integer_data(arg);
-               gasket_log_warn(
+               gasket_log_debug(
                        gasket_dev,
                        "Unknown ioctl cmd=0x%x not caught by "
                        "gasket_is_supported_ioctl",
@@ -329,7 +329,7 @@ static int gasket_partition_page_table(
                gasket_dev->page_table[ibuf.page_table_index]);
 
        if (ibuf.size > max_page_table_size) {
-               gasket_log_error(
+               gasket_log_debug(
                        gasket_dev,
                        "Partition request 0x%llx too large, max is 0x%x.",
                        ibuf.size, max_page_table_size);